Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add datamodels/terms-0.1.0 schema #587

Closed
wants to merge 3 commits into from

Conversation

CagtayFabry
Copy link
Member

Changes

  • draft changes to use general terms for datamodels

Related Issues

Closes #582

Checks

  • updated CHANGELOG.rst
  • updated tests
  • updated doc/
  • update example/tutorial notebooks
  • update manifest file

@CagtayFabry CagtayFabry added the ASDF everything ASDF related (python + schemas) label Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #587 (0b81bb6) into master (e011e4e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files          93       93           
  Lines        5745     5745           
=======================================
  Hits         5448     5448           
  Misses        297      297           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e011e4e...0b81bb6. Read the comment docs.

@CagtayFabry CagtayFabry requested review from vhirtham and removed request for vhirtham October 8, 2021 12:29
Copy link
Collaborator

@vhirtham vhirtham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CagtayFabry CagtayFabry added this to the 0.6.0 milestone Nov 3, 2021
@CagtayFabry
Copy link
Member Author

closing this for now in favor of #667

@CagtayFabry CagtayFabry closed this Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASDF everything ASDF related (python + schemas)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

split single_pass_weld schema into sub-references
2 participants